hrynco/hrynco-notification-service
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(notification): enable web smtp test with saved password #25

Merged
agrynco merged 1 commits from fix/notification-web-smtp-test into main 2026-10-18 00:20:42 +03:00
Conversation 0 Commits 1 Files Changed 9
+260 -5
agrynco commented 2026-10-18 00:17:32 +03:00
Owner
Copy Link
Copy Source

Scope

  • Allow the shared Notification Web pod public IPv4 SMTP egress on TCP 587, matching the Worker policy.
  • Make admin Send Test Email reuse an existing channel's saved password when the password field is blank and SMTP host, port, username, and TLS mode are unchanged. Explicitly typed passwords still win, and unsaved sender fields are tested without saving.
  • Document the production overlay and editor behavior. Keep the saved secret out of the rendered editor and test response.

Validation

  • .NET solution: 32 service tests and 126 Web integration tests passed.
  • Kubernetes package: 54 Python tests passed; overlay validated and live policy applied separately.
  • Web pod TCP 587 and STARTTLS succeeded. The live Web code is not yet updated, so end-to-end UI mail verification is pending deployment.
  • Independent code review found no actionable issues.

This PR is separate from the open IT-1601 Kubernetes localization PR #24.

Ref: IT-1601

## Scope - Allow the shared Notification Web pod public IPv4 SMTP egress on TCP 587, matching the Worker policy. - Make admin Send Test Email reuse an existing channel's saved password when the password field is blank and SMTP host, port, username, and TLS mode are unchanged. Explicitly typed passwords still win, and unsaved sender fields are tested without saving. - Document the production overlay and editor behavior. Keep the saved secret out of the rendered editor and test response. ## Validation - .NET solution: 32 service tests and 126 Web integration tests passed. - Kubernetes package: 54 Python tests passed; overlay validated and live policy applied separately. - Web pod TCP 587 and STARTTLS succeeded. The live Web code is not yet updated, so end-to-end UI mail verification is pending deployment. - Independent code review found no actionable issues. This PR is separate from the open IT-1601 Kubernetes localization PR #24. Ref: IT-1601
agrynco added 1 commit 2026-10-18 00:17:33 +03:00
fix(notification): enable web smtp test with saved password 2dd5e318d7 
Allow Web SMTP egress on TCP 587 and reuse the saved channel password only when connection settings match.

Ref: IT-1601
agrynco merged commit c5eee69018 into main 2026-10-18 00:20:42 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agrynco (Anatolii Hrynchuk)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hrynco/hrynco-notification-service#25
Delete Branch "fix/notification-web-smtp-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?