hrynco/hrynco-notification-service
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(notification): save smtp sender without reentering password #27

Merged
agrynco merged 1 commits from fix/notification-admin-save-password into main 2026-10-18 00:36:12 +03:00
Conversation 0 Commits 1 Files Changed 5
+184 -13
agrynco commented 2026-10-18 00:35:22 +03:00
Owner
Copy Link
Copy Source

Change

  • Keep the saved SMTP password when editing an existing channel without changing its connection settings.
  • Require a password for new channels and when changing SMTP connection settings.
  • Keep passwords out of rendered edit forms and document the behavior.

Validation

  • 8 focused Web integration tests passed.
  • Full solution: 32 service tests and 133 Web integration tests passed before the final added test; focused test rerun passed after it.
  • git diff --check passed.
  • Separate code review found no actionable issues.

Ref: IT-1601

## Change - Keep the saved SMTP password when editing an existing channel without changing its connection settings. - Require a password for new channels and when changing SMTP connection settings. - Keep passwords out of rendered edit forms and document the behavior. ## Validation - 8 focused Web integration tests passed. - Full solution: 32 service tests and 133 Web integration tests passed before the final added test; focused test rerun passed after it. - `git diff --check` passed. - Separate code review found no actionable issues. Ref: IT-1601
agrynco added 1 commit 2026-10-18 00:35:23 +03:00
fix(notification): save smtp sender without reentering password 1c028313ba 
Preserve the saved SMTP password when connection settings are unchanged and keep it out of admin forms.

Ref: IT-1601
agrynco merged commit b30dba93e8 into main 2026-10-18 00:36:12 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agrynco (Anatolii Hrynchuk)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hrynco/hrynco-notification-service#27
Delete Branch "fix/notification-admin-save-password"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?