Merge branch 'development'

fix: update RepositoryUrl in project files to correct domain
Merge pull request 'release: IT-631 fix EF repository base bugs' (#12 ) from development into main
2026-05-06 22:42:04 +03:00 · 2026-05-06 22:41:21 +03:00 · 2026-05-06 12:50:16 +03:00 · 2026-05-06 12:50:04 +03:00 · 2026-05-06 12:46:35 +03:00 · 2026-05-06 12:45:09 +03:00
3 changed files with 17 additions and 6 deletions
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net10.0</TargetFramework>
@@ -10,7 +10,8 @@
    <Description>Abstract DAL contracts for HrynCo applications: entities, repository and unit-of-work interfaces.</Description>
    <PackageTags>hrynco dal abstract entity repository unitofwork</PackageTags>
    <RepositoryType>git</RepositoryType>
-    <RepositoryUrl>https://gitea.grynco.com.ua/hrynco/hrynco-ef.git</RepositoryUrl>
+    <RepositoryUrl>https://gitea.hrynco.com/hrynco/hrynco-ef.git</RepositoryUrl>
  </PropertyGroup>

 </Project>
+
@@ -40,7 +40,12 @@ public abstract class BaseEfRepository<TDbContext, TEntity, TEntityId> :
    {
        foreach (TEntity entity in entities)
        {
-            Add(entity, save);
+            Add(entity, save: false);
+        }
+
+        if (save)
+        {
+            DbContext.SaveChanges();
        }
    }

@@ -84,7 +89,11 @@ public abstract class BaseEfRepository<TDbContext, TEntity, TEntityId> :

    public async Task DeleteAsync(TEntityId id)
    {
-        Delete(id);
+        TEntity? entity = await GetByIdAsync(id);
+        if (entity != null)
+        {
+            DoRemove(entity);
+        }
        await DbContext.SaveChangesAsync();
    }

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net10.0</TargetFramework>
@@ -10,7 +10,7 @@
    <Description>Entity Framework Core base implementations for HrynCo applications: generic repository and unit-of-work.</Description>
    <PackageTags>hrynco dal ef entityframework repository unitofwork</PackageTags>
    <RepositoryType>git</RepositoryType>
-    <RepositoryUrl>https://gitea.grynco.com.ua/hrynco/hrynco-ef.git</RepositoryUrl>
+    <RepositoryUrl>https://gitea.hrynco.com/hrynco/hrynco-ef.git</RepositoryUrl>
  </PropertyGroup>

  <ItemGroup>
@@ -28,3 +28,4 @@
  </ItemGroup>

 </Project>
+
Author	SHA1	Message	Date
Anatolii Grynchuk	584d036a09	Merge branch 'development'	2026-05-06 22:42:04 +03:00
Anatolii Grynchuk	1da2dd8579	fix: update RepositoryUrl in project files to correct domain	2026-05-06 22:41:21 +03:00
agrynco	b434383f7e	Merge pull request 'release: IT-631 fix EF repository base bugs' (#12 ) from development into main	2026-05-06 12:50:16 +03:00
agrynco	3f1371e33a	Merge pull request 'fix: use GetByIdAsync in DeleteAsync(TEntityId)' (#11 ) from IT-631-fix-delete-async-getbyid into development	2026-05-06 12:50:04 +03:00
Anatolii Grynchuk	9c1da388d8	fix: use GetByIdAsync in DeleteAsync(TEntityId) Replaced sync GetById with await GetByIdAsync to avoid blocking the thread inside an async method. Ref: #IT-631	2026-05-06 12:46:35 +03:00
agrynco	1edcafdebd	Merge pull request 'fix: eliminate multi-save in batch Add and DeleteAsync(TEntityId)' (#10 ) from IT-631-fix-delete into development	2026-05-06 12:45:09 +03:00
Anatolii Grynchuk	93461fd35e	fix: eliminate multi-save in batch Add and DeleteAsync(TEntityId) - Add(TEntity[]) now passes save:false in the loop and calls SaveChanges once at the end - DeleteAsync(TEntityId) now calls DoRemove directly instead of Delete(TEntityId) to avoid the double-save from the sync overload chain Ref: #IT-631	2026-05-06 12:43:27 +03:00